Conversation
tbot env var configurationstbot env var configurations
|
After reading documentation and taking a closer look, it seems like we don't really need proxy command. Having Seems like all we need is to provide default CMD |
| FROM $BASE_IMAGE | ||
| COPY --from=teleport /opt/staging/opt/teleport/system/bin/tbot /usr/local/bin/tbot | ||
| ENTRYPOINT ["/usr/local/bin/tbot"] | ||
| CMD ["start"] |
There was a problem hiding this comment.
This is not a breaking change as specifying CMD here just sets the default command.
Which will be overwritten by customers who use it in kubernetes, etc:
containers:
- name: tbot
image: public.ecr.aws/gravitational/tbot-distroless:17.2.7
args:
- start
- -c
- /config/tbot.yamlThere was a problem hiding this comment.
Same with the helm chart:
teleport/examples/chart/tbot/templates/deployment.yaml
Lines 50 to 57 in 3d50f12
There was a problem hiding this comment.
Even if it is a breaking change I'm in favor of making it anyway to unblock this - it's been annoying for a while. It may still interfere with some default behavior expectations so many it's worth mentioning in the changelog note? Heh, looks like you already did!
tbot env var configurationstbot env variable configurations
timothyb89
left a comment
There was a problem hiding this comment.
I was going to ask if the new tbot start <service> was insufficient but I guess GHA services can't accept CLI args at all, yikes 🤯
| FROM $BASE_IMAGE | ||
| COPY --from=teleport /opt/staging/opt/teleport/system/bin/tbot /usr/local/bin/tbot | ||
| ENTRYPOINT ["/usr/local/bin/tbot"] | ||
| CMD ["start"] |
There was a problem hiding this comment.
Even if it is a breaking change I'm in favor of making it anyway to unblock this - it's been annoying for a while. It may still interfere with some default behavior expectations so many it's worth mentioning in the changelog note? Heh, looks like you already did!
|
Amplify deployment status
|
cd8e653 to
db33097
Compare
db33097 to
0f88e4c
Compare
Summary
Add following env variable configurations for the
tbotcli:TBOT_DEBUG- enable debug modeTBOT_CONFIG_PATH- provide location to the tbot config via env variableTBOT_CONFIG- (hidden) provide base64 encoded tbot config, similarly like teleport doesteleport/tool/teleport/common/teleport.go
Lines 153 to 155 in 39a5fa3
startas defaultCMDintbot-distrolessimageAs result tbot tunnels can be created by running like:
Context
This will allow us to use
tbot-distrolessdocker image as Bitbucket Pipeline Service Container/Gitlab Services to start local tunnels as background process and use it in CI/CD steps.tbot proxyimage #52231changelog: Allow to provide
tbotconfigurations via environment variables. Updatetbot-distrolessimage to runstartcommand by default.