Move Identity Center validation tools to OSS#52239
Conversation
tcsc
added
no-changelog
public-teleport-github-review-bot
Bot
removed request for
flyinghermit,
hugoShaka and
zmb3
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
There was a problem hiding this comment.
Feels like /lib/aws/identitycenter/common would be a better package home for these ones. The /lib/utils/ is meant for a more generic packages that would apply to broader usage beside identity center.
There was a problem hiding this comment.
common is a pretty poor choice of package name though.. Tells you nothing about what's inside.
There was a problem hiding this comment.
There are also plenty of AWS-service specific utilities already under lib/utils/aws (see here), so it seems like a reasonable place to move these utils to.
Given the precedent of those other service-specific packages, I'm going to leave them here for now. This isn't a hill I'm prepared to die on, though; if we want to move them afterwards I'm OK with that.
There was a problem hiding this comment.
Hmm. That said, all of the filter management stuff has nothing to do with the AWS service; it's all Teleport stuff. OK, I'll move it.
In order to provide better validation when installing the IC integration via `tctl`, this patch moves some IC-specific validation tools from `teleport.e` to into the OSS repository.
tcsc
force-pushed
the
tcsc/aws-ic-move-validators
branch
from
76383ea to
2031bf9
Compare
In order to provide better validation when installing the IC integration via `tctl`, this patch moves some IC-specific validation tools from `teleport.e` to into the OSS repository.
5 participants
In order to provide better validation when installing the IC integration via
tctl,this patch moves some IC-specific validation tools from
teleport.etointo the OSS repository.