[v16] Prevent loading default config in tctl on Windows#52189
Merged
rosstimothy merged 1 commit intobranch/v16from Feb 14, 2025
Merged
[v16] Prevent loading default config in tctl on Windows#52189rosstimothy merged 1 commit intobranch/v16from
rosstimothy merged 1 commit intobranch/v16from
Conversation
On Windows tctl will attempt to load a teleport config file from the default path of C:\etc\teleport.yaml. However, on Windows, C:\etc\ does not exist by default, and may be created by any user. This could potentially allow an unprivileged user to trick tctl into loading a malicious teleport.yaml file and perform some kind of MITM attack. In practice, this attack would have to be quite sophisticated since tctl does check the data directory defined in the config file and requires a host_uuid and a valid admin identity before proceeding with using the local credentials. If this behavior is to be restored in the future, the default config path on Windows should be changed to something that respects Windows path conventions.
marcoandredinis
approved these changes
Feb 14, 2025
espadolini
approved these changes
Feb 14, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #52184 to branch/v16
Changelog: Removed the ability of
tctlto load the default configuration file on Windows.