Conversation
<Stack> (a variant of <Flex>`)<Stack> (a variant of <Flex>)
gzdunek
approved these changes
Feb 10, 2025
|
@ravicious See the table below for backport results.
|
|
@ravicious See the table below for backport results.
|
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
Flexvariant calledStack. It's basically just<Flex flexDirection="column" alignItems="flex-start">. Over time, I found myself reaching for it pretty often, especially in the new VNet diagnostic report that I'm working on. It gets pretty annoying to define it by hand whenever you want to use it, hence this PR.It's based on The Stack from Every Layout:
I've used
gapinstead ofmargin-blocklike Every Layout does because 1) it's what we already use 2) it has wider browser support.margin-top: auto