feat: Allow non-FIPS endpoints on FIPS binaries#51924
Merged
codingllama merged 6 commits intomasterfrom Feb 11, 2025
Merged
Conversation
codingllama
changed the title
codingllama
force-pushed
the
codingllama/aws-sts-fips
branch
from
cf93ae6 to
c44de74
Compare
codingllama
changed the title
codingllama
force-pushed
the
codingllama/aws-sts-fips
branch
2 times, most recently
from
127591b to
9858f97
Compare
github-actions
Bot
requested review from
creack,
fspmarshall,
greedy52 and
nklaassen
github-actions
Bot
added
application-access
audit-log
Contributor
Author
|
Setting roughly the same reviewers as #51932. |
Contributor
Author
codingllama
commented
Feb 10, 2025
codingllama
force-pushed
the
codingllama/aws-sts-fips
branch
from
9858f97 to
312cbde
Compare
nklaassen
reviewed
Feb 11, 2025
nklaassen
reviewed
Feb 11, 2025
nklaassen
approved these changes
Feb 11, 2025
rosstimothy
approved these changes
Feb 11, 2025
public-teleport-github-review-bot
Bot
removed request for
fspmarshall,
greedy52 and
vapopov
GavinFrazar
approved these changes
Feb 11, 2025
Contributor
Author
|
Thanks, everyone! Fixing forbidigo lint woes, will queue soon. I'll also cherry-pick any changes to the v15 PR (#51932). |
|
@codingllama See the table below for backport results.
|
This was referenced Feb 12, 2025
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
* Add the dynamodbutils and stsutils packages * Use stsutils.NewFromConfig() * Use stsutils.NewV1() * Use dynamodbutils.IsFIPSEnabled() * Add forbidigo rules * Appease linter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow FIPS binaries to use non-FIPS AWS endpoints of STS and DynamoDB. Useful for running in AWS regions that lack some of the FIPS services, but mostly ill-advised - talk to your FIPS auditors first.
The "escape hatch" is the TELEPORT_UNSTABLE_DISABLE_AWS_FIPS environment variable. Set it to yes|true|1 to enable it:
TELEPORT_UNSTABLE_DISABLE_AWS_FIPS=yes."Forward"-port of #51932.
Changelog: Added an escape hatch to allow non-FIPS AWS endpoints on FIPS binaries (TELEPORT_UNSTABLE_DISABLE_AWS_FIPS=yes).