Add bootstrap support for AutoUpdateConfig/AutoUpdateVersion resources#51904
Merged
Add bootstrap support for AutoUpdateConfig/AutoUpdateVersion resources#51904
Conversation
vapopov
added
no-changelog
hugoShaka
approved these changes
Feb 6, 2025
Contributor
hugoShaka
left a comment
hugoShaka
left a comment
There was a problem hiding this comment.
While you are adding --bootstrap support, do you mind adding --apply-on-startup support as well?
There's a switch in lib/auth/init.go:1427 and a priority map just above.
Reduce nested switch for bootstrap new type of resources
vapopov
force-pushed
the
vapopov/add-autoupdate-resources-unmarshal
branch
from
0db9a39 to
3584a8c
Compare
…rapResources` and `applyResources`
vapopov
force-pushed
the
vapopov/add-autoupdate-resources-unmarshal
branch
from
3584a8c to
1568a4a
Compare
Contributor
Author
|
@sclevine @fspmarshall @kiosion I would appreciate your review when you have time |
sclevine
approved these changes
Feb 6, 2025
Member
sclevine
left a comment
sclevine
left a comment
There was a problem hiding this comment.
Not sure my review will let you merge, but looks good!
Contributor
Author
|
@fspmarshall @kiosion could you please also take a look, need one more approval |
kiosion
approved these changes
Feb 8, 2025
Contributor
kiosion
left a comment
kiosion
left a comment
There was a problem hiding this comment.
apologies for the delay! not familiar with this area but LGTM
public-teleport-github-review-bot
bot
removed the request for review
from fspmarshall
vapopov
added a commit
that referenced
this pull request
Feb 10, 2025
#51904) * Add bootstrap support for AutoUpdateConfig/AutoUpdateVersion * Add support for `applyResources` Reduce nested switch for bootstrap new type of resources * Transform test to table test to check same resources for both `bootstrapResources` and `applyResources`
vapopov
added a commit
that referenced
this pull request
Feb 10, 2025
#51904) * Add bootstrap support for AutoUpdateConfig/AutoUpdateVersion * Add support for `applyResources` Reduce nested switch for bootstrap new type of resources * Transform test to table test to check same resources for both `bootstrapResources` and `applyResources`
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
gravitational#51904) * Add bootstrap support for AutoUpdateConfig/AutoUpdateVersion * Add support for `applyResources` Reduce nested switch for bootstrap new type of resources * Transform test to table test to check same resources for both `bootstrapResources` and `applyResources`
vapopov
added a commit
that referenced
this pull request
Mar 13, 2025
#51904) * Add bootstrap support for AutoUpdateConfig/AutoUpdateVersion * Add support for `applyResources` Reduce nested switch for bootstrap new type of resources * Transform test to table test to check same resources for both `bootstrapResources` and `applyResources`
vapopov
added a commit
that referenced
this pull request
Mar 13, 2025
#51904) * Add bootstrap support for AutoUpdateConfig/AutoUpdateVersion * Add support for `applyResources` Reduce nested switch for bootstrap new type of resources * Transform test to table test to check same resources for both `bootstrapResources` and `applyResources`
This was referenced Mar 13, 2025
vapopov
added a commit
that referenced
this pull request
Mar 13, 2025
#51904) * Add bootstrap support for AutoUpdateConfig/AutoUpdateVersion * Add support for `applyResources` Reduce nested switch for bootstrap new type of resources * Transform test to table test to check same resources for both `bootstrapResources` and `applyResources`
vapopov
added a commit
that referenced
this pull request
Mar 13, 2025
#51904) * Add bootstrap support for AutoUpdateConfig/AutoUpdateVersion * Add support for `applyResources` Reduce nested switch for bootstrap new type of resources * Transform test to table test to check same resources for both `bootstrapResources` and `applyResources`
vapopov
added a commit
that referenced
this pull request
Mar 14, 2025
#51904) * Add bootstrap support for AutoUpdateConfig/AutoUpdateVersion * Add support for `applyResources` Reduce nested switch for bootstrap new type of resources * Transform test to table test to check same resources for both `bootstrapResources` and `applyResources`
vapopov
added a commit
that referenced
this pull request
Mar 14, 2025
#51904) * Add bootstrap support for AutoUpdateConfig/AutoUpdateVersion * Add support for `applyResources` Reduce nested switch for bootstrap new type of resources * Transform test to table test to check same resources for both `bootstrapResources` and `applyResources`
vapopov
added a commit
that referenced
this pull request
Mar 14, 2025
#51904) * Add bootstrap support for AutoUpdateConfig/AutoUpdateVersion * Add support for `applyResources` Reduce nested switch for bootstrap new type of resources * Transform test to table test to check same resources for both `bootstrapResources` and `applyResources`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR added support to bootstrap AutoUpdateConfig/AutoUpdateVersion resources which is required for Cloud customers to be pre-created after onboarding
Related: