Skip to content

Use DynamoDB Streams FIPS endpoints #51896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rosstimothy merged 1 commit into from
Feb 6, 2025
Merged

Use DynamoDB Streams FIPS endpoints #51896

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions lib/backend/dynamo/dynamodbbk.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ func New(ctx context.Context, params backend.Params) (*Backend, error) {
}

// FIPS settings are applied on the individual service instead of the aws config,
// as DynamoDB Streams and Application Auto Scaling do not yet have FIPS endpoints in non-GovCloud.
// as Application Auto Scaling do not yet have FIPS endpoints in non-GovCloud.
// See also: https://aws.amazon.com/compliance/fips/#FIPS_Endpoints_by_Service
if modules.GetModules().IsBoringBinary() {
dynamoOpts = append(dynamoOpts, func(o *dynamodb.Options) {
Expand All @@ -312,7 +312,23 @@ func New(ctx context.Context, params backend.Params) (*Backend, error) {
return nil, trace.Wrap(err)
}

streamsClient := dynamodbstreams.NewFromConfig(awsConfig, dynamodbstreams.WithEndpointResolverV2(streamsResolver))
streamsOpts := []func(*dynamodbstreams.Options){
dynamodbstreams.WithEndpointResolverV2(streamsResolver),
func(o *dynamodbstreams.Options) {
o.TracerProvider = smithyoteltracing.Adapt(otel.GetTracerProvider())
},
}

// FIPS settings are applied on the individual service instead of the aws config,
// as Application Auto Scaling do not yet have FIPS endpoints in non-GovCloud.
Comment thread
codingllama marked this conversation as resolved.
// See also: https://aws.amazon.com/compliance/fips/#FIPS_Endpoints_by_Service
if modules.GetModules().IsBoringBinary() {
streamsOpts = append(streamsOpts, func(o *dynamodbstreams.Options) {
o.EndpointOptions.UseFIPSEndpoint = aws.FIPSEndpointStateEnabled
})
}

streamsClient := dynamodbstreams.NewFromConfig(awsConfig, streamsOpts...)
b := &Backend{
logger: l,
Config: *cfg,
Expand Down