kube: prevent init failure when proxy listener addr host is unspecified#51839
Merged
kube: prevent init failure when proxy listener addr host is unspecified#51839
Conversation
This PR fixes an issue caused by configuring Teleport proxy listener address without a host `:443` or in ipv6 form `[::]:443`. The call to `utils.SplitHostPort` was checking if the host was empty after the split which caused proxies to fail to initialize. `:443` is equivalent to `0.0.0.0:443`. Fixes #51838 Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
timothyb89
approved these changes
Feb 4, 2025
zmb3
approved these changes
Feb 4, 2025
public-teleport-github-review-bot
Bot
removed request for
creack and
smallinsky
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
…ed (gravitational#51839) * kube: prevent init failure when proxy listener addr host is unspecified This PR fixes an issue caused by configuring Teleport proxy listener address without a host `:443` or in ipv6 form `[::]:443`. The call to `utils.SplitHostPort` was checking if the host was empty after the split which caused proxies to fail to initialize. `:443` is equivalent to `0.0.0.0:443`. Fixes gravitational#51838 Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> * Update utils.go Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue caused by configuring Teleport proxy listener address without a host
:443or in ipv6 form[::]:443.The call to
utils.SplitHostPortwas checking if the host was empty after the split which caused proxies to fail to initialize.:443is equivalent to0.0.0.0:443.Fixes #51838
Changelog: Prevent Teleport proxy failing to initialize when listener address's host component is empty.