[v16] fix: Randomly derive UUIDs from non-conformant session IDs#51644
Merged
codingllama merged 1 commit intobranch/v16from Jan 30, 2025
Merged
[v16] fix: Randomly derive UUIDs from non-conformant session IDs#51644codingllama merged 1 commit intobranch/v16from
codingllama merged 1 commit intobranch/v16from
Conversation
* Tests event with non-UUID session ID * Randomly derive UUIDs from non-conformant session IDs * nit: Use "" instead of `` * Link godoc references to Log.deriveSessionID * Mention UUIDv5 for derived IDs * Do not log the session ID * Rename test helper, move truncateEvents out of it
github-actions
Bot
added
audit-log
espadolini
approved these changes
Jan 30, 2025
marcoandredinis
approved these changes
Jan 30, 2025
public-teleport-github-review-bot
Bot
removed the request for review
from kopiczko
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #51571 to branch/v16.
changelog: Fixes issue where the Postgres backend would drop App Access events