Skip to content

docs: add a dedicated section to desktop LDAP discovery#51515

Merged
zmb3 merged 1 commit intomasterfrom
zmb3/docs-ldap-discovery
Jan 29, 2025
Merged

docs: add a dedicated section to desktop LDAP discovery#51515
zmb3 merged 1 commit intomasterfrom
zmb3/docs-ldap-discovery

Conversation

@zmb3
Copy link
Copy Markdown
Collaborator

@zmb3 zmb3 commented Jan 27, 2025

Closes #51485

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 27, 2025

Amplify deployment status

Branch Commit Job ID Status Preview Updated (UTC)
zmb3/docs-ldap-discovery HEAD 1 ✅SUCCEED zmb3-docs-ldap-discovery 2025-01-27 19:52:00

@zmb3 zmb3 requested a review from ravicious January 28, 2025 14:38
Copy link
Copy Markdown
Member

@ravicious ravicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for a quick PR.

Copy link
Copy Markdown
Contributor

@ptgott ptgott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to add this as a guide to the auto-discovery section (https://goteleport.com/docs/enroll-resources/auto-discovery/)? We could also keep this section as part of the AD how-to guide and add a link to it from the Auto-Discovery section landing page. What do you think would be the most discoverable?

Edit: in terms of traffic, the enroll-resources/desktop-access section gets more, so it might make sense to keep this info in the how-to guide and add a link.

@zmb3
Copy link
Copy Markdown
Collaborator Author

zmb3 commented Jan 28, 2025

The auto discovery guide is really focused on teleports discovery service. I think I'd like to keep this here because ldap discovery runs in the windows desktop service, not the discovery service.

Copy link
Copy Markdown
Contributor

@ptgott ptgott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add one sentence to the first paragraph of this section explaining that the Desktop Service is what discovers desktops.

@zmb3 zmb3 added this pull request to the merge queue Jan 29, 2025
Merged via the queue into master with commit ac8640b Jan 29, 2025
@zmb3 zmb3 deleted the zmb3/docs-ldap-discovery branch January 29, 2025 20:10
@public-teleport-github-review-bot
Copy link
Copy Markdown

@zmb3 See the table below for backport results.

Branch Result
branch/v15 Failed
branch/v16 Failed
branch/v17 Create PR

@zmb3 zmb3 mentioned this pull request Jan 30, 2025
github-merge-queue Bot pushed a commit that referenced this pull request Jan 30, 2025
* docs: update CA import instructions for HSMs (#51530)

Now that #51301 is merged, we have the ability to get all of the
active user CA certificates.

* docs: add a dedicated section to desktop LDAP discovery (#51515)

Closes #51485
carloscastrojumo pushed a commit to carloscastrojumo/teleport that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/branch/v17 documentation no-changelog Indicates that a PR does not require a changelog entry size/sm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Desktop Access documentation should explain how to filter desktops with discovery.filters

3 participants