Add spring funcs to agent and tools autoupdate URL template#51511
Closed
Add spring funcs to agent and tools autoupdate URL template#51511
Conversation
hugoShaka
added
the
no-changelog
vapopov
approved these changes
Jan 27, 2025
sclevine
reviewed
Jan 27, 2025
| // We add sprig functions to have access to `semver` and be able to change the template in tests based on | ||
| // the version requested (e.g. pull pre-releases version from the dev repo, and official versions | ||
| // from the prod one). | ||
| tmpl, err := template.New("uri").Funcs(sprig.HermeticTxtFuncMap()).Parse(uriTmpl) |
Member
There was a problem hiding this comment.
We're removing the external template override in #51383, will that be a problem for this testing use case?
Contributor
Author
There was a problem hiding this comment.
This would require at least some way of passing a template and dynamically change the base-url depending on the build provenance.
Contributor
There was a problem hiding this comment.
Do we need to use sprig at all?
Contributor
Author
There was a problem hiding this comment.
For now we can add only semver and semverCompare to solve this use-case, but we'll have to document this somewhere. I can vendor the semver code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds sprig functions to the autoupdate URL template engine.