[v16] Add template for client tools auto-update download url#51478
Merged
vapopov merged 1 commit intobranch/v16from Jan 28, 2025
Merged
[v16] Add template for client tools auto-update download url#51478vapopov merged 1 commit intobranch/v16from
vapopov merged 1 commit intobranch/v16from
Conversation
* Add templates for client tools auto-update download url * Change to base url setting by env MakeURL moved to common function to be general for both, agent and client tools * Add godoc for common function and constant for default package * Use flags and version arguments instead of revision * Move base url env to shared constant
vapopov
added
backport
no-changelog
sclevine
approved these changes
Jan 25, 2025
Member
sclevine
left a comment
sclevine
left a comment
There was a problem hiding this comment.
Is there a reason this backport has no-changelog, but the v15 and v17 backports do not?
vapopov
removed
the
no-changelog
Contributor
Author
|
@sclevine muscle memory 🙃 I've removed label, thanks for noticing |
marcoandredinis
approved these changes
Jan 27, 2025
hugoShaka
approved these changes
Jan 27, 2025
public-teleport-github-review-bot
Bot
removed the request for review
from timothyb89
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #51210 to branch/v16
changelog: Added support for customizing the base URL for downloading Teleport packages used in client tools managed updates