Skip to content

Refactor integration CA export#51427

Merged
greedy52 merged 4 commits intomasterfrom
STeve/refactor/integration_ca_export
Jan 27, 2025
Merged

Refactor integration CA export#51427
greedy52 merged 4 commits intomasterfrom
STeve/refactor/integration_ca_export

Conversation

@greedy52
Copy link
Copy Markdown
Contributor

@greedy52 greedy52 commented Jan 23, 2025

related:

Added a new client.ExportIntegrationAuthorities function and removed integration from the existing export function.

@greedy52 greedy52 requested a review from codingllama January 24, 2025 15:02
@greedy52 greedy52 marked this pull request as ready for review January 24, 2025 15:02
@github-actions github-actions Bot added size/sm tctl tctl - Teleport admin tool labels Jan 24, 2025
@github-actions github-actions Bot requested review from avatus and tcsc January 24, 2025 15:02
@zmb3
Copy link
Copy Markdown
Collaborator

zmb3 commented Jan 24, 2025

What is an "integration CA"?

Copy link
Copy Markdown
Contributor

@codingllama codingllama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow-up, STeve!

Comment thread lib/client/ca_export.go Outdated
Comment thread lib/client/ca_export.go
Comment thread lib/client/ca_export.go Outdated
Comment thread lib/client/ca_export.go Outdated
Comment thread lib/client/ca_export.go
Comment thread lib/client/ca_export_test.go Outdated
Comment thread tool/tctl/common/auth_command.go Outdated
@greedy52 greedy52 added the no-changelog Indicates that a PR does not require a changelog entry label Jan 24, 2025
@greedy52 greedy52 requested a review from codingllama January 24, 2025 21:01
@greedy52
Copy link
Copy Markdown
Contributor Author

What is an "integration CA"?

Added a little more context in godoc of ExportIntegrationAuthorities

@greedy52 greedy52 added this pull request to the merge queue Jan 27, 2025
Merged via the queue into master with commit 4d7ce45 Jan 27, 2025
@greedy52 greedy52 deleted the STeve/refactor/integration_ca_export branch January 27, 2025 14:35
carloscastrojumo pushed a commit to carloscastrojumo/teleport that referenced this pull request Feb 19, 2025
* Refactor integration CA export

* remove UseCompatVersion

* add more comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog Indicates that a PR does not require a changelog entry size/sm tctl tctl - Teleport admin tool

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants