[v15] [gke] skip hard error when client misses permissions for some projects#51401
Merged
tigrato merged 1 commit intobranch/v15from Jan 23, 2025
Merged
[v15] [gke] skip hard error when client misses permissions for some projects#51401tigrato merged 1 commit intobranch/v15from
tigrato merged 1 commit intobranch/v15from
Conversation
#51344) This PR fixes a behavior problem that results in GKE discovery to completely fail when the client misses permissions in some of the discovered projects. If the client misses list permissions for projectID 1 but has the required permissions for projectID 2, the discovery service should continue with the projectID 2 discovery and skip the failing one. Fixes #48101 Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
ryanclark
approved these changes
Jan 23, 2025
marcoandredinis
approved these changes
Jan 23, 2025
public-teleport-github-review-bot
Bot
removed the request for review
from zmb3
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #51344 to branch/v15
Changelog: Fixed a bug in GKE auto-discovery where the process failed to discover any clusters if the identity lacked permissions for one or more detected GCP project IDs.