kube: properly return the reason for connection disruption#51398
Merged
kube: properly return the reason for connection disruption#51398
Conversation
There are several cases where connection monitor can terminate an ongoing connection. Iddle timeout, certificate expiring among others are some reasons for the connection to be terminated. For Kubernetes access, the underlying error is never propagated back to the client so they don't receive the reason for the exec session being terminated. This PR fixes that by adding an hook to write the client error response into the connection error channel for clients to be aware. Part of #18496
tigrato
force-pushed
the
tigrato/fix-kube-incorrect-messages
branch
from
cadd765 to
4bd836b
Compare
codingllama
reviewed
Jan 23, 2025
Contributor
codingllama
left a comment
codingllama
left a comment
There was a problem hiding this comment.
Overall seems reasonable, but I can't say I follow the subtleties of the lib/kube package. You'll probably want a kube reviewer to take a look too.
creack
approved these changes
Jan 23, 2025
codingllama
approved these changes
Jan 23, 2025
public-teleport-github-review-bot
Bot
removed request for
Tener,
ravicious,
rosstimothy and
zmb3
tigrato
added a commit
that referenced
this pull request
Jan 24, 2025
* kube: properly return the reason for connection disruption There are several cases where connection monitor can terminate an ongoing connection. Iddle timeout, certificate expiring among others are some reasons for the connection to be terminated. For Kubernetes access, the underlying error is never propagated back to the client so they don't receive the reason for the exec session being terminated. This PR fixes that by adding an hook to write the client error response into the connection error channel for clients to be aware. Part of #18496 * handle review comments * handle review comments
tigrato
added a commit
that referenced
this pull request
Jan 24, 2025
* kube: properly return the reason for connection disruption There are several cases where connection monitor can terminate an ongoing connection. Iddle timeout, certificate expiring among others are some reasons for the connection to be terminated. For Kubernetes access, the underlying error is never propagated back to the client so they don't receive the reason for the exec session being terminated. This PR fixes that by adding an hook to write the client error response into the connection error channel for clients to be aware. Part of #18496 * handle review comments * handle review comments
tigrato
added a commit
that referenced
this pull request
Jan 24, 2025
* kube: properly return the reason for connection disruption There are several cases where connection monitor can terminate an ongoing connection. Iddle timeout, certificate expiring among others are some reasons for the connection to be terminated. For Kubernetes access, the underlying error is never propagated back to the client so they don't receive the reason for the exec session being terminated. This PR fixes that by adding an hook to write the client error response into the connection error channel for clients to be aware. Part of #18496 * handle review comments * handle review comments
This was referenced Jan 24, 2025
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
) * kube: properly return the reason for connection disruption (#51398) * kube: properly return the reason for connection disruption There are several cases where connection monitor can terminate an ongoing connection. Iddle timeout, certificate expiring among others are some reasons for the connection to be terminated. For Kubernetes access, the underlying error is never propagated back to the client so they don't receive the reason for the exec session being terminated. This PR fixes that by adding an hook to write the client error response into the connection error channel for clients to be aware. Part of #18496 * handle review comments * handle review comments * fix slog ref
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
) * kube: properly return the reason for connection disruption (#51398) * kube: properly return the reason for connection disruption There are several cases where connection monitor can terminate an ongoing connection. Iddle timeout, certificate expiring among others are some reasons for the connection to be terminated. For Kubernetes access, the underlying error is never propagated back to the client so they don't receive the reason for the exec session being terminated. This PR fixes that by adding an hook to write the client error response into the connection error channel for clients to be aware. Part of #18496 * handle review comments * handle review comments * fix slog ref
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
) * kube: properly return the reason for connection disruption (#51398) * kube: properly return the reason for connection disruption There are several cases where connection monitor can terminate an ongoing connection. Iddle timeout, certificate expiring among others are some reasons for the connection to be terminated. For Kubernetes access, the underlying error is never propagated back to the client so they don't receive the reason for the exec session being terminated. This PR fixes that by adding an hook to write the client error response into the connection error channel for clients to be aware. Part of #18496 * handle review comments * handle review comments * fix slog ref * fix missing import
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
…onal#51398) * kube: properly return the reason for connection disruption There are several cases where connection monitor can terminate an ongoing connection. Iddle timeout, certificate expiring among others are some reasons for the connection to be terminated. For Kubernetes access, the underlying error is never propagated back to the client so they don't receive the reason for the exec session being terminated. This PR fixes that by adding an hook to write the client error response into the connection error channel for clients to be aware. Part of gravitational#18496 * handle review comments * handle review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are several cases where connection monitor can terminate an ongoing connection. Idle timeout, certificate expiring among others are some reasons for the connection to be terminated.
For Kubernetes access, the underlying error is never propagated back to the client so they don't receive the reason for the exec session being terminated.
This PR fixes that by adding an hook to write the client error response into the connection error channel for clients to be aware.
Part of #18496
Changelog: Improved handling of client session termination during Kubernetes Exec sessions. The disconnection reason is now accurately returned for cases such as certificate expiration, forced lock activation, or idle timeout.