Conversation
rosstimothy
reviewed
Jan 21, 2025
github-actions
Bot
requested review from
hugoShaka,
marcoandredinis and
tigrato
rosstimothy
reviewed
Jan 21, 2025
evanfreed
force-pushed
the
evan/pyroscope-integration
branch
from
0cc0c99 to
20aa08e
Compare
Signed-off-by: Evan Freed <evan.freed@goteleport.com>
evanfreed
force-pushed
the
evan/pyroscope-integration
branch
from
be1781f to
2fbfb7b
Compare
evanfreed
commented
Jan 22, 2025
rosstimothy
reviewed
Jan 22, 2025
Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
Signed-off-by: Evan Freed <evan.freed@goteleport.com>
Signed-off-by: Evan Freed <evan.freed@goteleport.com>
tigrato
approved these changes
Jan 23, 2025
rosstimothy
approved these changes
Jan 23, 2025
Contributor
rosstimothy
left a comment
rosstimothy
left a comment
There was a problem hiding this comment.
Looking forward to seeing this rolled out. Thanks Evan!
public-teleport-github-review-bot
Bot
removed request for
hugoShaka and
marcoandredinis
Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
|
@evanfreed See the table below for backport results.
|
evanfreed
added a commit
that referenced
this pull request
Jan 24, 2025
* feat: add pyroscope sdk support Signed-off-by: Evan Freed <evan.freed@goteleport.com> * Update lib/service/pyroscope.go Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> * Update lib/service/pyroscope.go Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> * Update lib/service/service.go Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> * review comments Signed-off-by: Evan Freed <evan.freed@goteleport.com> * license fix Signed-off-by: Evan Freed <evan.freed@goteleport.com> * Update lib/service/pyroscope.go Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> * fmt Signed-off-by: Evan Freed <evan.freed@goteleport.com> --------- Signed-off-by: Evan Freed <evan.freed@goteleport.com> Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
evanfreed
added a commit
that referenced
this pull request
Jan 24, 2025
* feat: add pyroscope sdk support Signed-off-by: Evan Freed <evan.freed@goteleport.com> * Update lib/service/pyroscope.go Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> * Update lib/service/pyroscope.go Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> * Update lib/service/service.go Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> * review comments Signed-off-by: Evan Freed <evan.freed@goteleport.com> * license fix Signed-off-by: Evan Freed <evan.freed@goteleport.com> * Update lib/service/pyroscope.go Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> * fmt Signed-off-by: Evan Freed <evan.freed@goteleport.com> --------- Signed-off-by: Evan Freed <evan.freed@goteleport.com> Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jan 27, 2025
* feat: add pyroscope sdk support * Update lib/service/pyroscope.go * Update lib/service/pyroscope.go * Update lib/service/service.go * review comments * license fix * Update lib/service/pyroscope.go * fmt --------- Signed-off-by: Evan Freed <evan.freed@goteleport.com> Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jan 27, 2025
* Add pyroscope support (#51294) * feat: add pyroscope sdk support Signed-off-by: Evan Freed <evan.freed@goteleport.com> * Update lib/service/pyroscope.go Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> * Update lib/service/pyroscope.go Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> * Update lib/service/service.go Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> * review comments Signed-off-by: Evan Freed <evan.freed@goteleport.com> * license fix Signed-off-by: Evan Freed <evan.freed@goteleport.com> * Update lib/service/pyroscope.go Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> * fmt Signed-off-by: Evan Freed <evan.freed@goteleport.com> --------- Signed-off-by: Evan Freed <evan.freed@goteleport.com> Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> * fix lint Signed-off-by: Evan Freed <evan.freed@goteleport.com> --------- Signed-off-by: Evan Freed <evan.freed@goteleport.com> Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
* feat: add pyroscope sdk support Signed-off-by: Evan Freed <evan.freed@goteleport.com> * Update lib/service/pyroscope.go Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> * Update lib/service/pyroscope.go Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> * Update lib/service/service.go Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> * review comments Signed-off-by: Evan Freed <evan.freed@goteleport.com> * license fix Signed-off-by: Evan Freed <evan.freed@goteleport.com> * Update lib/service/pyroscope.go Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> * fmt Signed-off-by: Evan Freed <evan.freed@goteleport.com> --------- Signed-off-by: Evan Freed <evan.freed@goteleport.com> Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Add support for continuous profile collection with Pyroscope