[Web] Update dashboard view to use sidenav#51237
Merged
Conversation
rudream
added
no-changelog
avatus
reviewed
Jan 21, 2025
Contributor
|
Everything works fine locally, but take a look at my suggestion to clean up the standlaone code |
rudream
force-pushed
the
yassine/dashboard-sidenav
branch
from
c5a04f3 to
bd04b02
Compare
avatus
reviewed
Jan 21, 2025
avatus
approved these changes
Jan 21, 2025
kiosion
approved these changes
Jan 21, 2025
public-teleport-github-review-bot
Bot
removed the request for review
from ryanclark
This was referenced Jan 22, 2025
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
* update dashboard view to use sidenav * delete old nav * CR * CR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
ecounterpart: https://github.com/gravitational/teleport.e/pull/5887This PR updates the dashboard view to use the sidenav, previously, it would fallback to the top bar. The top bar has also been deleted in this PR since it is no longer used anywhere.
Additionally, any features that should be shown in the navigation for dashboards will now require a
showInDashboardflag. All features are hidden from the dashboard by default unless this flag is set totrue.Figma design: https://www.figma.com/design/Gpjs9vjhzUKF1GDbeG9JGE/Application-Design-System?node-id=18005-14042&m=dev
*One deviation from the design is the exclusion of the
Supportsection, this is redundant to have here since it is already in the top navigation dropdown (when you click on your username on the top right)I recommend reviewing commit by commit, since replacing the old nav files with the new nav makes the overall diff look like I just edited the original nav's files.
Demo