[v16] Fix auto-update re-exec arguments modified by aliases#51182
Merged
vapopov merged 1 commit intobranch/v16from Jan 18, 2025
Merged
[v16] Fix auto-update re-exec arguments modified by aliases#51182vapopov merged 1 commit intobranch/v16from
vapopov merged 1 commit intobranch/v16from
Conversation
github-actions
Bot
added
size/md
tctl
* Fix auto-update re-exec arguments modified by aliases * Make arguments to be required to set * Restore progress bar show before request * Improve integration tests to execute with `tsh` and `tctl` Added a full-cycle integration test to verify client tools auto-updates within a test cluster by modifying AutoUpdateConfig and AutoUpdateVersion resources. The test executes the login command using alias configurations to ensure no recursive re-execution occurs. The updater binary used in integration tests has been replaced with the `Run` logic of tctl and tsh. * Set generated test password by env variable instead of constant value * Restore priority of env check over remote check In case of double re-execution case we should stop second one to prevent loop re-execution Drop localDir set during compilation
vapopov
force-pushed
the
vapopov/fix-autoupdate-re-exec-with-aliases-v16
branch
from
4913cb2 to
16de128
Compare
tigrato
approved these changes
Jan 17, 2025
timothyb89
approved these changes
Jan 18, 2025
public-teleport-github-review-bot
Bot
removed request for
Tener,
hugoShaka and
sclevine
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #50228 to branch/v16
changelog: Fixed client tools auto-updates executed by aliases (causes recursive alias error)