[v17] Fix auto-update re-exec arguments modified by aliases#51154
Merged
vapopov merged 6 commits intobranch/v17from Jan 17, 2025
Merged
[v17] Fix auto-update re-exec arguments modified by aliases#51154vapopov merged 6 commits intobranch/v17from
vapopov merged 6 commits intobranch/v17from
Conversation
Added a full-cycle integration test to verify client tools auto-updates within a test cluster by modifying AutoUpdateConfig and AutoUpdateVersion resources. The test executes the login command using alias configurations to ensure no recursive re-execution occurs. The updater binary used in integration tests has been replaced with the `Run` logic of tctl and tsh.
In case of double re-execution case we should stop second one to prevent loop re-execution Drop localDir set during compilation
github-actions
Bot
added
backport
size/md
tctl
Tener
approved these changes
Jan 17, 2025
Contributor
Tener
left a comment
Tener
left a comment
There was a problem hiding this comment.
nit: the commits are unverified for some reason? Probably a configuration issue somewhere.
hugoShaka
approved these changes
Jan 17, 2025
public-teleport-github-review-bot
Bot
removed the request for review
from sclevine
Contributor
Author
@Tener this is configuration of my github account, to show commits not signed by me 🙂 they were created by backport bot |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #50228 to branch/v17
changelog: Fixed client tools autoupdates executed by aliases (causes recursive alias error)