Fix HTTPS thumbprint lookup test#51152
Merged
marcoandredinis merged 1 commit intomasterfrom Jan 17, 2025
Merged
Conversation
Go 1.23.5 changed the certificate (added another host), and the thumbprint is now different. Instead of updating the thumbprint, we now rely on the presented certificate by the TLS Server. This should ensure the test doesn't break again if the test certificate is changed again.
marcoandredinis
added
no-changelog
espadolini
approved these changes
Jan 17, 2025
gzdunek
approved these changes
Jan 17, 2025
|
@marcoandredinis See the table below for backport results.
|
marcoandredinis
added a commit
that referenced
this pull request
Jan 17, 2025
Go 1.23.5 changed the certificate (added another host), and the thumbprint is now different. Instead of updating the thumbprint, we now rely on the presented certificate by the TLS Server. This should ensure the test doesn't break again if the test certificate is changed again.
marcoandredinis
added a commit
that referenced
this pull request
Jan 17, 2025
Go 1.23.5 changed the certificate (added another host), and the thumbprint is now different. Instead of updating the thumbprint, we now rely on the presented certificate by the TLS Server. This should ensure the test doesn't break again if the test certificate is changed again.
Contributor
|
Many thanks for the quick fix, Marco! |
marcoandredinis
added a commit
that referenced
this pull request
Jan 17, 2025
Go 1.23.5 changed the certificate (added another host), and the thumbprint is now different. Instead of updating the thumbprint, we now rely on the presented certificate by the TLS Server. This should ensure the test doesn't break again if the test certificate is changed again.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jan 17, 2025
* Fix HTTPS thumbprint lookup test (#51152) Go 1.23.5 changed the certificate (added another host), and the thumbprint is now different. Instead of updating the thumbprint, we now rely on the presented certificate by the TLS Server. This should ensure the test doesn't break again if the test certificate is changed again. * fix panic
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jan 17, 2025
* Fix HTTPS thumbprint lookup test (#51152) Go 1.23.5 changed the certificate (added another host), and the thumbprint is now different. Instead of updating the thumbprint, we now rely on the presented certificate by the TLS Server. This should ensure the test doesn't break again if the test certificate is changed again. * fix panic
mvbrock
pushed a commit
that referenced
this pull request
Jan 18, 2025
Go 1.23.5 changed the certificate (added another host), and the thumbprint is now different. Instead of updating the thumbprint, we now rely on the presented certificate by the TLS Server. This should ensure the test doesn't break again if the test certificate is changed again.
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
Go 1.23.5 changed the certificate (added another host), and the thumbprint is now different. Instead of updating the thumbprint, we now rely on the presented certificate by the TLS Server. This should ensure the test doesn't break again if the test certificate is changed again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go 1.23.5 changed the certificate (added another host), and the thumbprint is now different.
Instead of updating the thumbprint, we now rely on the presented certificate by the TLS Server.
This should ensure the test doesn't break again if the test certificate is changed again.