Skip to content

[v16] Fix TestWatcherCloudFetchers flakiness #51098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GavinFrazar merged 1 commit into from
Jan 16, 2025
Merged

[v16] Fix TestWatcherCloudFetchers flakiness #51098

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions lib/srv/db/watcher_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,16 @@ func TestWatcherCloudFetchers(t *testing.T) {
testCtx.setupDatabaseServer(ctx, t, agentParams{
// Keep ResourceMatchers as nil to disable resource matchers.
OnReconcile: func(d types.Databases) {
if len(d) == 0 {
// The dynamic resource matchers and cloud watchers will both
// trigger a reconciliation, but dynamic matchers should return
// 0 resources from first init, whereas the cloud watchers
// should return databases.
// Dynamic matchers are included in config to test that the
// dynamic matcher AWS settings are not applied to cloud watcher
// databases.
return
}
reconcileCh <- d
},
ResourceMatchers: []services.ResourceMatcher{{
Expand Down