Remove any notion of teleport namespace from tsh#51076
Merged
rosstimothy merged 1 commit intomasterfrom Jan 15, 2025
Merged
Conversation
github-actions
Bot
added
size/sm
tsh
rosstimothy
added
the
no-changelog
codingllama
approved these changes
Jan 15, 2025
espadolini
approved these changes
Jan 15, 2025
public-teleport-github-review-bot
Bot
removed the request for review
from doggydogworld
Updates #49509. Most of the places namespaces were already configurable were had been forcing the default namespace. This extends that by removing the ability to pass in a custom namesapce and hardcodes the default namespace at the inner most call site to reduce the surface area of namespaces. With the removal of the --namespace flag from the base tsh command, kubernetes subcommands have also been updated to use --namespaces in addition to --kube-namespace. The former should be preferred, while the later exists solely for backward compatibility.
rosstimothy
force-pushed
the
tross/tsh_namespace
branch
from
8d811c1 to
cd4eb82
Compare
This was referenced Jan 17, 2025
mvbrock
pushed a commit
that referenced
this pull request
Jan 18, 2025
Updates #49509. Most of the places namespaces were already configurable were had been forcing the default namespace. This extends that by removing the ability to pass in a custom namesapce and hardcodes the default namespace at the inner most call site to reduce the surface area of namespaces. With the removal of the --namespace flag from the base tsh command, kubernetes subcommands have also been updated to use --namespaces in addition to --kube-namespace. The former should be preferred, while the later exists solely for backward compatibility.
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
Updates gravitational#49509. Most of the places namespaces were already configurable were had been forcing the default namespace. This extends that by removing the ability to pass in a custom namesapce and hardcodes the default namespace at the inner most call site to reduce the surface area of namespaces. With the removal of the --namespace flag from the base tsh command, kubernetes subcommands have also been updated to use --namespaces in addition to --kube-namespace. The former should be preferred, while the later exists solely for backward compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates #49509.
Most of the places namespaces were already configurable were had been forcing the default namespace. This extends that by removing the ability to pass in a custom namespace and hardcodes the default namespace at the inner most call site to reduce the surface area of namespaces.
With the removal of the
--namespaceflag from the basetshcommand, kubernetes subcommands have also been updated to use--namespacesin addition to--kube-namespace. The former should be preferred, while the later exists solely for backward compatibility.