Add invited and reason fields to SessionStartEvent#51070
Merged
Conversation
tigrato
reviewed
Jan 15, 2025
rosstimothy
force-pushed
the
tross/enrich_session_start_event
branch
from
156c1e5 to
292e196
Compare
github-actions
Bot
added
kubernetes-access
size/sm
tsh
rosstimothy
force-pushed
the
tross/enrich_session_start_event
branch
from
292e196 to
7412dbd
Compare
tigrato
approved these changes
Jan 15, 2025
rosstimothy
force-pushed
the
tross/enrich_session_start_event
branch
2 times, most recently
from
5784705 to
9911cbd
Compare
tigrato
approved these changes
Jan 16, 2025
tigrato
reviewed
Jan 16, 2025
Tener
approved these changes
Jan 17, 2025
Contributor
Tener
left a comment
Tener
left a comment
There was a problem hiding this comment.
Nit: changelog should mention the kube change too.
In addition to adding the new fields and populating them, this also updates tsh kube exec to include a --namespace flag similar to tsh kube login to make the command easier and more intuitive to use. Closes #51019.
rosstimothy
force-pushed
the
tross/enrich_session_start_event
branch
from
26d5898 to
5f590b5
Compare
|
@rosstimothy See the table below for backport results.
|
rosstimothy
added a commit
that referenced
this pull request
Jan 17, 2025
In addition to adding the new fields and populating them, this also updates tsh kube exec to include a --kube-namespace flag similar to tsh kube login to make the command easier and more intuitive to use. Closes #51019.
rosstimothy
added a commit
that referenced
this pull request
Jan 17, 2025
In addition to adding the new fields and populating them, this also updates tsh kube exec to include a --kube-namespace flag similar to tsh kube login to make the command easier and more intuitive to use. Closes #51019.
rosstimothy
added a commit
that referenced
this pull request
Jan 17, 2025
In addition to adding the new fields and populating them, this also updates tsh kube exec to include a --kube-namespace flag similar to tsh kube login to make the command easier and more intuitive to use. Closes #51019.
rosstimothy
added a commit
that referenced
this pull request
Jan 17, 2025
In addition to adding the new fields and populating them, this also updates tsh kube exec to include a --kube-namespace flag similar to tsh kube login to make the command easier and more intuitive to use. Closes #51019.
rosstimothy
added a commit
that referenced
this pull request
Jan 17, 2025
In addition to adding the new fields and populating them, this also updates tsh kube exec to include a --kube-namespace flag similar to tsh kube login to make the command easier and more intuitive to use. Closes #51019.
rosstimothy
added a commit
that referenced
this pull request
Jan 17, 2025
In addition to adding the new fields and populating them, this also updates tsh kube exec to include a --kube-namespace flag similar to tsh kube login to make the command easier and more intuitive to use. Closes #51019.
mvbrock
pushed a commit
that referenced
this pull request
Jan 18, 2025
In addition to adding the new fields and populating them, this also updates tsh kube exec to include a --namespace flag similar to tsh kube login to make the command easier and more intuitive to use. Closes #51019.
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
In addition to adding the new fields and populating them, this also updates tsh kube exec to include a --namespace flag similar to tsh kube login to make the command easier and more intuitive to use. Closes gravitational#51019.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to adding the new fields and populating them, this also updates
tsh kube execto include a--namespaceflag similar totsh kube loginto make the command easier and more intuitive to use.Closes #51019.
Changelog: Include invited and reason fields in SessionStartEvents
Changelog: Add a flag to
tsh kube execto allow specifying the namespace outside of the Kubernetes context