[v17] Only apply dynamic AWS settings to dynamic AWS dbs#51039
Merged
GavinFrazar merged 1 commit intobranch/v17from Jan 14, 2025
Merged
[v17] Only apply dynamic AWS settings to dynamic AWS dbs#51039GavinFrazar merged 1 commit intobranch/v17from
GavinFrazar merged 1 commit intobranch/v17from
Conversation
GavinFrazar
added
aws
greedy52
approved these changes
Jan 14, 2025
Dynamic database resource matchers can include AWS settings to assume an AWS IAM role when they match a database. The settings should only be applied to dynamic AWS databases. The db service will no longer apply these settings to non-AWS databases. It will also no longer apply these settings to databases discovered by the legacy cloud watchers in db_service.aws - the cloud watchers have an assume_role_arn setting that should not be overridden by dynamic database matcher settings. * fix reconcilitation race
GavinFrazar
force-pushed
the
gavinfrazar/v17-fix-db-assume-role-arn
branch
from
230107d to
3a76da2
Compare
r0mant
approved these changes
Jan 14, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Fixed a Database Service bug where
db_service.resources.aws.assume_role_arnsettings could affect non-AWS dynamic databases or incorrectly overridedb_service.aws.assume_role_arnsettings.Backports #50970 to branch/v17.