Skip to content

[v17] WebDiscover: supports defining labels for Discover flows with single resource enroll#51038

Merged
kimlisa merged 4 commits intobranch/v17from
lisa/v17/frontend-labels
Jan 15, 2025
Merged

[v17] WebDiscover: supports defining labels for Discover flows with single resource enroll#51038
kimlisa merged 4 commits intobranch/v17from
lisa/v17/frontend-labels

Conversation

@kimlisa
Copy link
Copy Markdown
Contributor

@kimlisa kimlisa commented Jan 14, 2025

backports #50606 #50853 #50976 #51058 to branch/v17

manual, but all commits were cleanly cherry-picked

changelog: Adds support for defining labels in the web UI Discover flows for single resource enroll (server, AWS and web applications, Kubernetes, EKS, RDS)

@kimlisa kimlisa changed the title Lisa/v17/frontend labels WebDiscover: supports defining labels for Discover flows with single resource enroll Jan 14, 2025
@github-actions github-actions Bot requested review from ravicious and rudream January 14, 2025 19:46
@kimlisa kimlisa changed the base branch from branch/v17 to lisa/v17/backend-labels January 14, 2025 19:46
@kimlisa kimlisa changed the title WebDiscover: supports defining labels for Discover flows with single resource enroll [v17] WebDiscover: supports defining labels for Discover flows with single resource enroll Jan 14, 2025
@kimlisa kimlisa force-pushed the lisa/v17/backend-labels branch from 0b5fe71 to c48ec81 Compare January 15, 2025 19:08
@kimlisa kimlisa force-pushed the lisa/v17/frontend-labels branch from 306903f to 93928b4 Compare January 15, 2025 19:13
Base automatically changed from lisa/v17/backend-labels to branch/v17 January 15, 2025 21:25
…on (#50853)

* Allow labels for generic add web app flow

* Update test
* WebDiscover: allow setting labels when enrolling aws app

* Address CRs
@kimlisa kimlisa force-pushed the lisa/v17/frontend-labels branch from 93928b4 to 466ba11 Compare January 15, 2025 21:33
* Implement a fallback hook for re-use

* Split v1 and v2 endpoints into separate funcs

* Provide fallback for create app access

* Provide fallback for join token suspender

* Provide fallback for eks

* Provide fallback for app

* Address CRs
@kimlisa kimlisa enabled auto-merge January 15, 2025 21:43
@kimlisa kimlisa disabled auto-merge January 15, 2025 21:43
@kimlisa kimlisa added this pull request to the merge queue Jan 15, 2025
Merged via the queue into branch/v17 with commit d6d6299 Jan 15, 2025
@kimlisa kimlisa deleted the lisa/v17/frontend-labels branch January 15, 2025 22:57
@camscale camscale mentioned this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants