[v16] Reorganize tctl commands to not require an auth client by default#50968
Merged
vapopov merged 2 commits intobranch/v16from Jan 23, 2025
Merged
[v16] Reorganize tctl commands to not require an auth client by default#50968vapopov merged 2 commits intobranch/v16from
vapopov merged 2 commits intobranch/v16from
Conversation
…8894) * Reorganize tctl commands to have commands not required auth client * Replace auth client with lazy loading approach * Fix linter warning * Replace camel case in import alias Replace logrus to use slog * Rename close function * Refactor plugin commands to use interface of auth client and plugin client Code review changes * Refactor workload identity commands * Add access to global config for the commands * Add test checking all tctl commands match process * Fix golangci-lint warnings
vapopov
added
backport
no-changelog
github-actions
Bot
added
size/md
tctl
github-actions
Bot
requested review from
Joerger,
hugoShaka,
rosstimothy and
zmb3
hugoShaka
approved these changes
Jan 14, 2025
Joerger
approved these changes
Jan 14, 2025
public-teleport-github-review-bot
Bot
removed request for
rosstimothy and
zmb3
…ient-lazy-loading-v16
codingllama
reviewed
Jan 24, 2025
| // TryRun is executed after the CLI parsing is done. The command must | ||
| // determine if selectedCommand belongs to it and return match=true | ||
| TryRun(ctx context.Context, selectedCommand string, c *authclient.Client) (match bool, err error) | ||
| TryRun(ctx context.Context, cmd string, clientFunc commonclient.InitFunc) (match bool, err error) |
Contributor
There was a problem hiding this comment.
This broke e/ due to the signature change.
Contributor
Author
There was a problem hiding this comment.
should have updated teleport.e reference after merging https://github.com/gravitational/teleport.e/pull/5851
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #48894 to branch/v16