Merged
Conversation
The refactoring done in #50451 caused the trace.Error debug report to be quoted in log output. This updates the quoting bypass used for log level to also consider trace.Errors in order to restore the previous output.
GavinFrazar
approved these changes
Jan 6, 2025
ravicious
approved these changes
Jan 7, 2025
|
@rosstimothy See the table below for backport results.
|
This was referenced Jan 7, 2025
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
The refactoring done in gravitational#50451 caused the trace.Error debug report to be quoted in log output. This updates the quoting bypass used for log level to also consider trace.Errors in order to restore the previous output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The refactoring done in #50451 caused the trace.Error debug report to be quoted in log output. This updates the quoting bypass used for log level to also consider trace.Errors in order to restore the previous output.
Changelog: Prevent quoting errors in log messages.