[v17] tsh proxy app: Add support for multi-port TCP apps#50691
Merged
ravicious merged 2 commits intobranch/v17from Jan 8, 2025
Merged
[v17] tsh proxy app: Add support for multi-port TCP apps#50691ravicious merged 2 commits intobranch/v17from
tsh proxy app: Add support for multi-port TCP apps#50691ravicious merged 2 commits intobranch/v17from
Conversation
* Pass around PortMapping rather than port as string * Pass target port to local proxy * Validate target port * Accept target-port flag in tsh app login * Don't reuse certs for multi-port apps * Add a test for multi-port tsh proxy app * Use strings.Cut instead of strings.SplitN * Remove appInfo from localProxyApp * Remove unused method appInfo.appLocalCAPath
github-actions
Bot
added
backport
size/md
tsh
ravicious
changed the title
tsh proxy app: Add support for multi-port TCP appstsh proxy app: Add support for multi-port TCP apps
Collaborator
|
/excludeflake * |
v17 is still on v1.9.0 of testify which expects you to use assert functions.
Member
Author
|
@espadolini @Joerger new year's ping |
espadolini
approved these changes
Jan 7, 2025
codingllama
approved these changes
Jan 8, 2025
public-teleport-github-review-bot
Bot
removed the request for review
from Joerger
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #50429
changelog: Added support for multi-port TCP apps to
tsh proxy app