Conversation
creack
changed the title
creack
force-pushed
the
creack/eks-sdk-v2
branch
4 times, most recently
from
2c56eb2 to
8de9fdc
Compare
creack
force-pushed
the
creack/eks-sdk-v2
branch
from
7174944 to
d968a0e
Compare
github-actions
bot
added
database-access
creack
added
the
no-changelog
creack
changed the title
rosstimothy
reviewed
Jan 6, 2025
tigrato
reviewed
Jan 8, 2025
Comment on lines
+352
to
+359
| type EKSClient interface { | ||
| eks.DescribeClusterAPIClient | ||
| } | ||
|
|
||
| // STSClient is the subset of the STS Client interface we use. | ||
| type STSClient interface { | ||
| stscreds.AssumeRoleAPIClient | ||
| } |
Contributor
There was a problem hiding this comment.
If our goal is to expose on those two interfaces, why not referring them directly?
This is mostly internal packages and I don't see them being expanded in the future
Contributor
Author
There was a problem hiding this comment.
it is easier to have them split as one is implemented by sts.Client the other by eks.Client, used in different places.
GavinFrazar
reviewed
Jan 8, 2025
creack
force-pushed
the
creack/eks-sdk-v2
branch
from
fb8c72e to
1ef1f91
Compare
GavinFrazar
approved these changes
Jan 10, 2025
Contributor
GavinFrazar
left a comment
GavinFrazar
left a comment
There was a problem hiding this comment.
LGTM - thanks for putting up with all the merge conflicts 😉
rosstimothy
approved these changes
Jan 10, 2025
public-teleport-github-review-bot
bot
removed the request for review
from greedy52
creack
force-pushed
the
creack/eks-sdk-v2
branch
from
ee87f36 to
4039237
Compare
tigrato
reviewed
Jan 10, 2025
creack
force-pushed
the
creack/eks-sdk-v2
branch
from
4039237 to
47449d5
Compare
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
* Remove all references to EKS sdk v1. * Address PR comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #49129
Removes all usage of sdk v1 for EKS.