Merged
Conversation
Note: I removed the subtests from TestTokens since they were not independendent tests - the ls subtest could only succeed if the add subtest ran first. Closes #46388
avatus
approved these changes
Dec 30, 2024
Contributor
avatus
left a comment
avatus
left a comment
There was a problem hiding this comment.
Looks good.
I'm wondering if we should add labels to the webui as well? Not in this pr of course. The problem stated in the issue isn't really a big deal in the web ui since we have the search functionality so i don't think its a big issue, just thinking out loud
public-teleport-github-review-bot
Bot
removed the request for review
from nklaassen
zmb3
added
no-changelog
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This was referenced Dec 30, 2024
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
Note: I removed the subtests from TestTokens since they were not independendent tests - the ls subtest could only succeed if the add subtest ran first. Closes gravitational#46388
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: I removed the subtests from TestTokens since they were not independendent tests - the ls subtest could only succeed if the add subtest ran first.
Closes #46388
Changelog: Add a --labels flag to the tctl tokens ls command.