Follow up on Web MFA TODOs

[Joerger]

Address TODOS from the recent flight of Web MFA PRs.

Depends on https://github.com/gravitational/teleport.e/pull/5727

[ryanclark]

I don't think the e ref should be in this PR

[Joerger]

After https://github.com/gravitational/teleport.e/pull/5727 is merged, I'll update the e ref will to master before merging. Or do you think the e ref update is a standalone PR?

[ryanclark]

Hm, I thought we all normally put e ref updates into a separate PR, but I'm not sure if it really matters. Just thought it might've been accidental

[Joerger]

I thought we all normally put e ref updates into a separate PR

Usually you'd have an e PR dependent on a teleport PR, so you'd do:

• telport PR
• e PR
• teleport PR to update e Ref

But in this case the teleport PR is dependent on the e PR, so we could do:

• e PR
• teleport PR
• teleport PR to update e Ref

IMO it makes more sense to just combine the last two PRs.

[rudream]

Yeah, usually we do OSS PR -> e PR -> update e-ref because e PR's typically need their OSS PR otherwise they'll break, since this e PR won't break without OSS, I think it's fine to save on the extra PR and just update the e ref here.

Just note that you'll need to change the e ref update here after the e PR is merged, since the e commit hash may not be the same after it's merged into master.

[ryanclark]

Will approve once https://github.com/gravitational/teleport.e/pull/5727 is in and e ref is updated

[Joerger]

@ryanclark e ref now points to master

[public-teleport-github-review-bot]

@Joerger See the table below for backport results.

Branch	Result
branch/v17	Failed