Filter while paging in GetByVMID#49968
Merged
rosstimothy merged 1 commit intomasterfrom Dec 10, 2024
Merged
Conversation
rosstimothy
added
the
no-changelog
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
This updates GetByVMID, used by azure joining, to filter by id for each page of vms instead of filtering after accumulating _all_ vms in memory first. While this does reduce memory consumption, the listing process is still suboptimal in that _all_ instances in a subscription are retrieved in response to _every_ join request.
rosstimothy
force-pushed
the
tross/azure_getvm
branch
from
9a1c37d to
f2c6832
Compare
Contributor
|
Related to https://github.com/gravitational/teleport.e/issues/2164 We can stop listing the VMs entirely and parse the token. |
hugoShaka
reviewed
Dec 9, 2024
Contributor
Author
I agree that azure joining is flawed, however, this seemed like a relatively low fruit to address until we make a decision on how to proceed improving azure joining. |
rosstimothy
added
backport/branch/v15
backport/branch/v17
and removed
no-changelog
hugoShaka
approved these changes
Dec 9, 2024
zmb3
approved these changes
Dec 10, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from gzdunek
|
@rosstimothy See the table below for backport results.
|
This was referenced Dec 10, 2024
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
This updates GetByVMID, used by azure joining, to filter by id for each page of vms instead of filtering after accumulating _all_ vms in memory first. While this does reduce memory consumption, the listing process is still suboptimal in that _all_ instances in a subscription are retrieved in response to _every_ join request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates GetByVMID, used by azure joining, to filter by id for each page of vms instead of filtering after accumulating all vms in memory first. While this does reduce memory consumption, the listing process is still suboptimal in that all instances in a subscription are retrieved in response to every join request.
Changelog: Reduce Auth memory consumption when agents join using the azure join method.