Add uri flag for s3 path style addressing configuration#49835
Add uri flag for s3 path style addressing configuration#49835EdwardDowling merged 2 commits intomasterfrom
Conversation
|
This change looks good to me, but should probably have the storage backend doc reflect the change: https://github.com/gravitational/teleport/blob/master/docs/pages/reference/backends.mdx#s3-session-recordings I think we'd only need to add this bullet point underneath the
I'm happy to add this doc commit to the branch for this PR if it's helpful. |
Added it in there |
|
Amplify deployment status
|
|
@hugoShaka @tcsc Can you take a look at this when you get a chance |
|
Can we do a real-world test against an s3 backend not supporting path-style adressing and see if we can make teleport work? Or maybe send a dev build to the affected customer? |
r0mant
left a comment
There was a problem hiding this comment.
lgtm after you fix the docs
r0mant
left a comment
There was a problem hiding this comment.
Please make sure to retest everything again since we've inverted the flag here and if everything is ok let's ship it.
5a4f54a to
aabc379
Compare
|
Confirmation that the dev build worked for the customer here |
|
@EdwardDowling See the table below for backport results.
|
Add ability to disable path-style S3 access for third-party endpoints.
part of: #48451
Fixes https://github.com/gravitational/customer-sensitive-requests/issues/346
changelog: Add ability to disable path-style S3 access for third-party endpoints.