Fix absence of the Symlinks parameter for Destination when using tbot kube credentials

[verdel]

The problem is described in the issue. After the tbot CLI refactoring, the bot.Destination object created for the directory specified in the --destination-dir parameter does not have default values set for the Symlinks attribute.

Fixes #49802

[timothyb89]

Thanks for catching this! I'll make a note to audit other codepaths to make sure there aren't any other missing CheckAndSetDefaults() calls.

[verdel]

@timothyb89, can I do anything to help and speed up the review process of this PR?

[zmb3]

@timothyb89 feel free to open a buddy PR for this so we can push it through CI.

[timothyb89]

Hi @verdel, I've created an internal PR for this due some CI limitations for external contributions on our end: #50370

CI looks to be passing and I don't anticipate much in the way of review feedback, but if anything comes up I'll sync any changes here back over to that PR. Otherwise, we'll get this merged and backported to v17 as soon as it gets through review. You'll retain authorship of your commits.

We'll close this PR and the associated issue once the internal PR is merged.

[verdel]

@timothyb89, Thank you for the PR status update and the additional recommendations with the alternative temporary solution for the issue. I will wait for the acceptance of PR #50370.

[timothyb89]

The fix and its v17 backport have been merged, so I'll close this PR. Thanks again @verdel!