[buddy] feat(charts): Give the possibility to add labels on more resources#49624
Merged
[buddy] feat(charts): Give the possibility to add labels on more resources#49624
Conversation
Currently it's possible to add labels on Jobs but not on Pods created by the Job. Let's allow it. Same problem on operator subchart for deployments and pod created by the deployment.
Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
github-actions
Bot
requested review from
hugoShaka,
marcoandredinis,
mmcallister,
ptgott,
r0mant,
xinding33 and
zmb3
marcoandredinis
approved these changes
Dec 2, 2024
Contributor
|
🤖 Vercel preview here: https://docs-d4whle6um-goteleport.vercel.app/docs |
zmb3
approved these changes
Dec 2, 2024
public-teleport-github-review-bot
Bot
removed request for
hugoShaka,
mmcallister,
ptgott,
r0mant and
xinding33
hugoShaka
approved these changes
Dec 2, 2024
Contributor
|
🤖 Vercel preview here: https://docs-f0rpzx0rw-goteleport.vercel.app/docs |
tigrato
force-pushed
the
tigrato/pr-buddy-49501
branch
from
cdc3d2d to
7213e0f
Compare
tigrato
force-pushed
the
tigrato/pr-buddy-49501
branch
from
7213e0f to
745afae
Compare
Contributor
|
🤖 Vercel preview here: https://docs-43rcxmqsi-goteleport.vercel.app/docs |
Contributor
|
🤖 Vercel preview here: https://docs-3fvc4v2rs-goteleport.vercel.app/docs |
This was referenced Dec 2, 2024
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
…urces (gravitational#49624) * feat(charts): Give the possibility to add labels on more resources Currently it's possible to add labels on Jobs but not on Pods created by the Job. Let's allow it. Same problem on operator subchart for deployments and pod created by the deployment. * Fix doc indentation * fix typo --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> Co-authored-by: emmanuel.lagree <emmanuel.lagree@mirakl.com> Co-authored-by: Emmanuel Lagrée <36861662+elagree@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently it's possible to add labels on Jobs but not on Pods created by the Job. Let's allow it.
Same problem on operator subchart for deployments and pod created by the deployment.
Buddy PR for #49501
Changelog: Add ability to configure resource labels in
teleport-cluster's operator sub-chart.