Fix TestDynamicIdentityFileCreds for Go 1.23#49597
Merged
codingllama merged 1 commit intomasterfrom Dec 2, 2024
Merged
Conversation
codingllama
added
the
no-changelog
Contributor
Author
|
This keeps failing for me locally so I took the easy way out while the more high-level discussion of "should our helpers set the leaf" progresses. |
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
strideynet
approved these changes
Dec 2, 2024
marcoandredinis
approved these changes
Dec 2, 2024
public-teleport-github-review-bot
Bot
removed request for
avatus and
flyinghermit
codingllama
added a commit
that referenced
this pull request
Dec 2, 2024
codingllama
added a commit
that referenced
this pull request
Dec 2, 2024
codingllama
added a commit
that referenced
this pull request
Dec 2, 2024
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go 1.23 changed the behavior of tls.X509KeyPair and tls.LoadX509KeyPair to populate the certificate leaf, which makes the assertions on TestDynamicIdentityFileCreds fail.
The PR changes the test to expect a nil leaf, which matches the behavior of the code under test.
Closes #49541.