[v17] Show device trust status in Connect#49577
Merged
gzdunek merged 1 commit intobranch/v17from Nov 29, 2024
Merged
Conversation
* Check if device is trusted * Move `TrustedDeviceRequirement` enum to a separate file and generate TS definitions for it Generating TS definitions for the entire legacy/types/types.proto would result in 50K lines of generated code, and the bundle size would increase by ~20% (around 1 MB). * Extract function to calculate device trust requirement that can be used both by the server and the client Important: it now uses `GetEnforcementMode` instead of `GetEffectiveMode`. The check for OSS module is performed on the server-side anyway. * Check what is device trust requirement based on cluster config and user roles * Show device trust status in UI * Remove `types.` prefix * Improve godocs * Bring back `getRoles func() ([]types.Role, error)` * Simplify `TestHasDeviceTrustExtensions` * Clean up and improve `TestCalculateTrustedDeviceRequirement` * Move `CalculateTrustedDeviceRequirement` and tests to a separate file * Add colors to shield icons * Declare variables where they are used * Extract a component to display device trust status for better readability * Correctly reference `lib/client.ProfileStatus.Extensions` * Set group limit to 8 * Make `switch` exhaustive * Regenerate protos * `make fix-license` (cherry picked from commit 095b0a3)
ravicious
approved these changes
Nov 29, 2024
codingllama
approved these changes
Nov 29, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from avatus
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #49508 to branch/v17
Manual backport because of a conflict in the generated protobuf file.
Changelog: Teleport Connect now shows whether it is being used on a trusted device or if enrollment is required for full access