Skip to content

fix build error on 32bit environment#495

Merged
kontsevoy merged 1 commit intogravitational:masterfrom
gaoyifan:master
Aug 9, 2016
Merged

fix build error on 32bit environment#495
kontsevoy merged 1 commit intogravitational:masterfrom
gaoyifan:master

Conversation

@gaoyifan
Copy link
Copy Markdown
Contributor

@gaoyifan gaoyifan commented Aug 8, 2016

fix the following compile error:

make -f version.mk setver
make[1]: Entering directory '/home/yifan/go_user/src/github.com/gravitational/teleport'
make[1]: Leaving directory '/home/yifan/go_user/src/github.com/gravitational/teleport'
go build -o build/teleport -i -ldflags -w ./tool/teleport
go build -o build/tctl -i -ldflags -w ./tool/tctl
# github.com/gravitational/teleport/vendor/github.com/buger/goterm
vendor/github.com/buger/goterm/terminal.go:106: constant 2147483648 overflows int
vendor/github.com/buger/goterm/terminal.go:110: constant 2147483648 overflows int
Makefile:34: recipe for target 'tctl' failed
make: *** [tctl] Error 2

@gravitational-jenkins
Copy link
Copy Markdown

Can one of the admins verify this patch?

@sofuture
Copy link
Copy Markdown
Contributor

sofuture commented Aug 8, 2016

Hey @gaoyifan thanks for the patch! I think we'll probably make this change by vendoring a newer version of github.com/buger/goterm -- it looks like a PR with the same fix was just accepted there buger/goterm#4

@sofuture
Copy link
Copy Markdown
Contributor

sofuture commented Aug 8, 2016

Can you update this PR with a godep update github.com/buger/goterm?

@sofuture
Copy link
Copy Markdown
Contributor

sofuture commented Aug 9, 2016

ok to test

@sofuture
Copy link
Copy Markdown
Contributor

sofuture commented Aug 9, 2016

@kontsevoy gonna kick this over to you

@kontsevoy kontsevoy merged commit 1547982 into gravitational:master Aug 9, 2016
@kontsevoy
Copy link
Copy Markdown
Contributor

thanks @gaoyifan

hatched pushed a commit to hatched/teleport-merge that referenced this pull request Nov 30, 2022
* first version

* Fix build

* Fix

* fixes

* add app context

* Add Navigator

* more screens

* add cluster

* grpc

* Add gateways

* add node-pty

* add tshd daemon

* add main process quick reload

* add tsh access

* Use default terminal shell and add context menu (gravitational#444)

* node-pty errors

* Fix build process and include `tsh` in the package  (gravitational#451)

* Use single `package.json` config

* Include `tsh` in app package

* fix linux package target

* add global search

* fix tsc (errors) build step

* Add mocks

* Add logging to file (gravitational#455)

* minor cleanups

* Add keyboard shortcuts service (gravitational#462)

* add sync statuses for teleport resources

* add teleterm icon (gravitational#470)

* Fix dev reloads of main process

* minore bug fixes

* implement auth

* update webpack configs to v5 (gravitational#492)

* arrange the cards evenly depending on the available space & add drag and drop (gravitational#486)

* fix text truncation on tabs

* Add logout and cluster removal

* Add context menu to clusters (gravitational#500)

* Add tabs shortcuts & open new tab basing on active tab (gravitational#495)

* Make xterm understand resize sequence (gravitational#507)

* use `Immer` in teleterm store (gravitational#516)

* Add apps and kubes

* Teleterm bugfixes (gravitational#519)

* add command palette

* Replace Gateways with Connections

* add tc

* Clean up

* Add basic config service (gravitational#526)

* add fonts config (gravitational#528)

* Fix resize bug

* Minor teleterm fixes (gravitational#531)

* remove exit code checking before closing a tab

* prevent closing `home` tab

* Fix crashing errors

* Remove Roles and Activities

* Remove GlobalSearch

* Add context menu to tab items (gravitational#533)

* make quickIInput always visible on top

* Add workspace service (gravitational#538)

* Add recently opened documents to workspace (gravitational#547)

* add recently opened documents to workspace

* review fixes

* review fixes

* add `ClusterConnect` component

* remove the `close` item and electron help items from the app menu (gravitational#560)

* improve navigator behaviour (gravitational#565)

* improve navigator behaviour

* Add new connection handling

* Add username to gateways

* add kube connect command

* Gateway should render instructions per DB protocol

* Address design changes

Co-authored-by: gzdunek <gzdunek@users.noreply.github.com>
hatched pushed a commit that referenced this pull request Dec 20, 2022
* first version

* Fix build

* Fix

* fixes

* add app context

* Add Navigator

* more screens

* add cluster

* grpc

* Add gateways

* add node-pty

* add tshd daemon

* add main process quick reload

* add tsh access

* Use default terminal shell and add context menu (#444)

* node-pty errors

* Fix build process and include `tsh` in the package  (#451)

* Use single `package.json` config

* Include `tsh` in app package

* fix linux package target

* add global search

* fix tsc (errors) build step

* Add mocks

* Add logging to file (#455)

* minor cleanups

* Add keyboard shortcuts service (#462)

* add sync statuses for teleport resources

* add teleterm icon (#470)

* Fix dev reloads of main process

* minore bug fixes

* implement auth

* update webpack configs to v5 (#492)

* arrange the cards evenly depending on the available space & add drag and drop (#486)

* fix text truncation on tabs

* Add logout and cluster removal

* Add context menu to clusters (#500)

* Add tabs shortcuts & open new tab basing on active tab (#495)

* Make xterm understand resize sequence (#507)

* use `Immer` in teleterm store (#516)

* Add apps and kubes

* Teleterm bugfixes (#519)

* add command palette

* Replace Gateways with Connections

* add tc

* Clean up

* Add basic config service (#526)

* add fonts config (#528)

* Fix resize bug

* Minor teleterm fixes (#531)

* remove exit code checking before closing a tab

* prevent closing `home` tab

* Fix crashing errors

* Remove Roles and Activities

* Remove GlobalSearch

* Add context menu to tab items (#533)

* make quickIInput always visible on top

* Add workspace service (#538)

* Add recently opened documents to workspace (#547)

* add recently opened documents to workspace

* review fixes

* review fixes

* add `ClusterConnect` component

* remove the `close` item and electron help items from the app menu (#560)

* improve navigator behaviour (#565)

* improve navigator behaviour

* Add new connection handling

* Add username to gateways

* add kube connect command

* Gateway should render instructions per DB protocol

* Address design changes

Co-authored-by: gzdunek <gzdunek@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants