[v16] Machine ID: Add bitbucket join method for Bitbucket Pipelines joining#49337
Merged
timothyb89 merged 3 commits intobranch/v16from Nov 27, 2024
Merged
Conversation
…ng (#48724) * Add `bitbucket` join method for Bitbucket Pipelines joining This adds a new `bitbucket` join method that Machine ID bots can use to authenticate to Teleport from Bitbucket Pipelines CI runs. * Add unit tests for bitbucket joining This also fully adds `deployment_environment_uuid` which was found to be missing. * Fix imports * Update tf docs * Docs update * Update generated TF resources * Attempt to work around docs linter * Add provision token tests * Remove pipeline_uuid and step_uuid from protos Also, fix deploment_environment_uuid field name. * Remove references to removed fields in tests * Switch to go-oidc/v3 and remove now-redundant nbf check * Fix go.mod imports for the TF provider * Fix event-handler go.mod * Address review feedback; add 15s timeout to fetch provider metadata * Update lib/bitbucket/token_validator.go Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> * Fix build after constant rename --------- Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
|
@timothyb89 - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
github-actions
Bot
requested review from
hugoShaka,
rosstimothy,
strideynet,
tigrato and
zmb3
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
zmb3
changed the title
bitbucket join method for Bitbucket Pipelines joining (#48724)bitbucket join method for Bitbucket Pipelines joining
Contributor
|
🤖 Vercel preview here: https://docs-41fp79jj8-goteleport.vercel.app/docs |
rosstimothy
approved these changes
Nov 22, 2024
hugoShaka
approved these changes
Nov 22, 2024
public-teleport-github-review-bot
Bot
removed request for
strideynet,
tigrato and
zmb3
…bitbucket-pipelines-joining
Contributor
|
🤖 Vercel preview here: https://docs-3yn0tmu0j-goteleport.vercel.app/docs |
Contributor
Author
|
Successfully retested this backport on my test cluster. Custom build at https://builds.cursed.industries/teleport-v16.4.8-linux-amd64-bin.tar.gz for anyone curious. Only minor changes from master and v17, though |
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #48724 for branch/v16
bitbucketjoin method for Bitbucket Pipelines joiningThis adds a new
bitbucketjoin method that Machine ID bots can use to authenticate to Teleport from Bitbucket Pipelines CI runs.This also fully adds
deployment_environment_uuidwhich was found to be missing.Fix imports
Update tf docs
Docs update
Update generated TF resources
Attempt to work around docs linter
Add provision token tests
Remove pipeline_uuid and step_uuid from protos
Also, fix deploment_environment_uuid field name.
Remove references to removed fields in tests
Switch to go-oidc/v3 and remove now-redundant nbf check
Fix go.mod imports for the TF provider
Fix event-handler go.mod
Address review feedback; add 15s timeout to fetch provider metadata
Update lib/bitbucket/token_validator.go
Fix build after constant rename
changelog: Support delegated joining for Bitbucket Pipelines in Machine ID