Grant secret watch permission to the operator#49324
Merged
Conversation
tigrato
approved these changes
Nov 21, 2024
marcoandredinis
approved these changes
Nov 21, 2024
|
@hugoShaka See the table below for backport results.
|
This was referenced Nov 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#48896 was missing the
watchverbConfirmed that it works now.
Note: those issues happened because the operator's kube client tries to be smart and maintain a local secret cache. This doesn't happen as long as users don't use secret injection. I don't think it's a bad thing, but some users might see high memory usage if they have thousands of secrets in their namespace. If this happens we'll have to craft another client, not caching secrets.
Changelog: fix a bug in the Teleport Operator chart that causes the operator to not be able to watch secrets during secret injection.