[v17] Azure join method - use subscription ID from attested data#49156
Merged
atburke merged 1 commit intobranch/v17from Nov 19, 2024
Merged
[v17] Azure join method - use subscription ID from attested data#49156atburke merged 1 commit intobranch/v17from
atburke merged 1 commit intobranch/v17from
Conversation
This change updates the Azure join method to look up VMs based on the subscription ID provided in the VM's attested data, rather than the subscription ID derived from its access token.
marcoandredinis
approved these changes
Nov 19, 2024
avatus
approved these changes
Nov 19, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from nklaassen
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #48707 to branch/v17
changelog: Allow Azure VMs to join from a different subscription than their managed identity