Refresh resources after dropping an access request #49125
Merged
Conversation
ravicious
reviewed
Nov 18, 2024
avatus
approved these changes
Nov 18, 2024
ravicious
approved these changes
Nov 20, 2024
Member
ravicious
left a comment
ravicious
left a comment
There was a problem hiding this comment.
Good idea and great execution. 👏
Member
|
It actually feels so nice that this works now and has been implemented in an elegant way. |
gzdunek
added a commit
that referenced
this pull request
Nov 22, 2024
* Pass `rootClusterUri` to functions in `ResourcesContext` * Support refreshing resources per cluster URI in unified resources * Move `ResourcesContextProvider` higher in component hierarchy * Refresh resources after dropping request * Fix casing of Assume Roles button * Add `rootClusterUri` as an argument to `useResourcesContext` * Change the error message * Change one more usage of `requestResourcesRefresh(rootClusterUri)` * Move `onResourcesRefreshRequest` listener logic to `ResourcesContextProvider` * Remove unnecessary `props.clusterUri` from deps (cherry picked from commit b3f1c0b)
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
* Pass `rootClusterUri` to functions in `ResourcesContext` * Support refreshing resources per cluster URI in unified resources * Move `ResourcesContextProvider` higher in component hierarchy * Refresh resources after dropping request * Fix casing of Assume Roles button * Add `rootClusterUri` as an argument to `useResourcesContext` * Change the error message * Change one more usage of `requestResourcesRefresh(rootClusterUri)` * Move `onResourcesRefreshRequest` listener logic to `ResourcesContextProvider` * Remove unnecessary `props.clusterUri` from deps (cherry picked from commit b3f1c0b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #42381
As mentioned in the linked issue, we were unable to refresh resources after dropping an access request because
ResourcesContextwas lower in the component tree, so we simply couldn't access it.A simple fix for this problem is to move it higher in the tree and add a root cluster URI as an argument to its functions, so we can still refresh resources within a single workspace.
Changelog: Teleport Connect now refreshes the resources view after dropping an access request