Fix a mistake causing document reopen dialog to be always hidden#49061
Merged
Fix a mistake causing document reopen dialog to be always hidden#49061
Conversation
ravicious
approved these changes
Nov 15, 2024
gzdunek
added
the
no-changelog
ravicious
reviewed
Nov 15, 2024
|
|
||
| return ( | ||
| <DialogConfirmation | ||
| open={!history} |
Member
There was a problem hiding this comment.
Heh, I'm not sure if there's a single lint rule which would help here. :D Even no-implicit-coercion wouldn't catch this. https://eslint.org/docs/latest/rules/no-implicit-coercion
Contributor
Author
There was a problem hiding this comment.
I think https://eslint.org/docs/latest/rules/no-restricted-globals could help 🧐
avatus
approved these changes
Nov 15, 2024
gzdunek
added a commit
that referenced
this pull request
Dec 3, 2024
) (cherry picked from commit 7b520cc)
gzdunek
added a commit
that referenced
this pull request
Dec 4, 2024
) (cherry picked from commit 7b520cc)
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
…ess (#49702) * Allow displaying hardware keys prompts when relogin is in progress (#48813) * Convert `DialogConfirmation` to TS * Allow `DialogConfirmation` and `Modal` to be hidden using CSS while closed * Allow hiding all dialogs that are displayed as important * Allow displaying multiple important dialogs, separate regular and important dialogs and get rid of `DialogNone` * Pass `hidden` prop to important dialogs * Rename `importantModalSemaphore` to `singleImportantModalSemaphore` * Remove semaphores from hardware key prompts * `keepMounted` -> `keepInDOMAfterClose` * Remove the explicit value from `keepInDOMAfterClose` * Revert splitting dialogs into regular and important ones, pass `hidden` to all of them, hide regular modal when important one is visible * Use random id as a modal key * Improve `singleImportantModalSemaphore` comment * Improve `NewHardwareKeyPromptConstructor` comment * Do not acquire important modal semaphore in MFA prompt and relogin, give each prompt its own mutex/semaphore (cherry picked from commit 7428128) * Re-add `keepInDOMAfterClose` to `Modal.jsx` * Fix a mistake causing document reopen dialog to be always hidden (#49061) (cherry picked from commit 7b520cc) * Change `dialogCss` type to `any` since there is no `StyleFunction` available in `styled-components` in branch/v16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to type
hiddenand autocomplete changed it tohistoryand I didn't notice it 🤦I verified other dialogs, they are fine.