[v16] Teleterm: fix incorrect cluster URI when fetching kube namespaces on a leaf cluster#48990
Merged
kimlisa merged 2 commits intobranch/v16from Nov 14, 2024
Merged
[v16] Teleterm: fix incorrect cluster URI when fetching kube namespaces on a leaf cluster#48990kimlisa merged 2 commits intobranch/v16from
kimlisa merged 2 commits intobranch/v16from
Conversation
…a leaf cluster (access request) (#48786) * Use tc.SiteName over cluster.Name * Teleterm: fix fetching namespaces with incorrect cluster URI If you add a root and leaf kube cluster,and on leaf Teleport cluster, listing namespaces for root kube cluster was referring to incorrect Teleport cluster URI * Teleterm: fix re-ordering of selected namespaces when done selecting Web UI still has this weird re-ordering because web UI still stores resource ids in a map which doesn't preserve order * Add requested length test * Address CR * Address CRs
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
avatus
approved these changes
Nov 14, 2024
flyinghermit
approved these changes
Nov 14, 2024
public-teleport-github-review-bot
Bot
removed request for
gzdunek and
ravicious
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport #48786 to branch/v16
conflict with pb file, fixed with
make grpcchangelog: Fix incorrect cluster name when querying for Kubernetes namespaces on a leaf cluster for Connect UI.