Skip to content

Fix "tsh app login" prompting for user login when multiple AWS roles are present#48716

Merged
greedy52 merged 3 commits intomasterfrom
STeve/48715_fix_tsh_app_login_multi_identity
Nov 14, 2024
Merged

Fix "tsh app login" prompting for user login when multiple AWS roles are present#48716
greedy52 merged 3 commits intomasterfrom
STeve/48715_fix_tsh_app_login_multi_identity

Conversation

@greedy52
Copy link
Copy Markdown
Contributor

@greedy52 greedy52 commented Nov 8, 2024

changelog: Fix "tsh app login" prompting for user login when multiple AWS roles are present

Fixes #48715

Thanks @codingllama for suggesting the non-retryable error check.

@greedy52 greedy52 requested a review from codingllama November 8, 2024 21:38
@greedy52 greedy52 self-assigned this Nov 8, 2024
@github-actions github-actions Bot added size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels Nov 8, 2024
Comment thread lib/client/api.go Outdated
@aws-amplify-us-west-2
Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-48716.d3pp5qlev8mo18.amplifyapp.com

Copy link
Copy Markdown
Contributor

@codingllama codingllama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread lib/client/api.go Outdated
Comment thread lib/client/api.go Outdated
Comment thread lib/client/api.go Outdated
Comment thread lib/client/api.go Outdated
Comment thread lib/client/api_test.go Outdated
Comment thread lib/client/api_test.go Outdated
@greedy52 greedy52 requested a review from codingllama November 11, 2024 16:09
Comment thread lib/client/api.go
@greedy52 greedy52 enabled auto-merge November 14, 2024 16:31
@greedy52 greedy52 added this pull request to the merge queue Nov 14, 2024
Merged via the queue into master with commit 7f15309 Nov 14, 2024
@greedy52 greedy52 deleted the STeve/48715_fix_tsh_app_login_multi_identity branch November 14, 2024 17:06
@public-teleport-github-review-bot
Copy link
Copy Markdown

@greedy52 See the table below for backport results.

Branch Result
branch/v16 Create PR
branch/v17 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/branch/v17 size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tsh apps login prompt for relogin when multiple cloud identities are available

4 participants