Do not require user interaction in tsh status when using hardware keys#48705
Merged
Do not require user interaction in tsh status when using hardware keys#48705
tsh status when using hardware keys#48705Conversation
avatus
approved these changes
Nov 11, 2024
Joerger
approved these changes
Nov 12, 2024
This was referenced Nov 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #20849,
tsh statusshouldn't require user interaction. Unfortunately, since that PR was merged, another remote call has been added that may prompt the user for touch/PIN.I looked at other usages of
onStatusand I believe all of them should be fine with this change. We probably don't need showing access lists to review after creating or dropping an access request.However, the main reason I opened this PR is that the user is not even able to respond to the prompt:
This happens since #47091. We added there a "warm up" call (it prompts for touch/PIN) that ensures the key is ready before we initiate a gRPC dialing. That call receives a context, but unfortunately for
tsh statusit has a really short deadline - 750 ms, so the user is not even able to provide a PIN or touch.