feat(helm-teleport-cluster): allow to override enterprise license name#48690
Closed
guntiskarulis wants to merge 1 commit intogravitational:masterfrom
Closed
feat(helm-teleport-cluster): allow to override enterprise license name#48690guntiskarulis wants to merge 1 commit intogravitational:masterfrom
guntiskarulis wants to merge 1 commit intogravitational:masterfrom
Conversation
|
|
github-actions
Bot
requested review from
hugoShaka,
klizhentas,
marcoandredinis,
mmcallister,
ptgott,
r0mant,
tigrato,
xinding33 and
zmb3
hugoShaka
approved these changes
Nov 8, 2024
Contributor
hugoShaka
left a comment
hugoShaka
left a comment
There was a problem hiding this comment.
Thank you for the high quality PR with tests and docs, looks good to me once the only comment is addressed.
tigrato
approved these changes
Nov 8, 2024
Signed-off-by: Guntis Karulis <guntis.karulis@gmail.com>
guntiskarulis
had a problem deploying
to
vercel
GitHub Actions
Failure
Contributor
|
Hi @guntiskarulis, Thanks for your contribution. We are currently unable to run our tests on Please wait for another approver and I'll get your |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to override hardcoded Kubernetes secret name (i.e. license) for the Enterprise license.