Skip to content

[v15] Machine ID: Support overriding Proxy address from ProxyPing when using TLS routing#48677

Merged
strideynet merged 2 commits intobranch/v15from
strideynet/v15/backport-48373
Nov 8, 2024
Merged

[v15] Machine ID: Support overriding Proxy address from ProxyPing when using TLS routing#48677
strideynet merged 2 commits intobranch/v15from
strideynet/v15/backport-48373

Conversation

@strideynet
Copy link
Copy Markdown
Contributor

Backports #48373
Backports #48667

changelog: Machine ID can now be forced to use the explicitly configured proxy address using the TBOT_USE_PROXY_ADDR environment variable. This should better support split proxy address operation.

…g TLS routing (#48373)

* Start working on ability to use explicit proxy address

* Convert more call-sites to use new helper

* Convert final callsite

* Simplify implementation

* Fix teests

* Remove additional check

* Fix dialling auth client

* Update env var name
)

* Prefer "yes" over "1" for historical consistency

* Try and retrigger the CLA check with an empty commit
@aws-amplify-us-west-2
Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-48677.d1v2yqnl3ruxch.amplifyapp.com

@public-teleport-github-review-bot public-teleport-github-review-bot Bot removed the request for review from timothyb89 November 8, 2024 16:31
@strideynet strideynet added this pull request to the merge queue Nov 8, 2024
Merged via the queue into branch/v15 with commit 05f44b6 Nov 8, 2024
@strideynet strideynet deleted the strideynet/v15/backport-48373 branch November 8, 2024 17:00
@camscale camscale mentioned this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants