Skip to content

Reduce log spam generated by conflicting session_id and event_index#48548

Merged
rosstimothy merged 1 commit intomasterfrom
tross/dynamo_conflict_logs
Nov 7, 2024
Merged

Reduce log spam generated by conflicting session_id and event_index#48548
rosstimothy merged 1 commit intomasterfrom
tross/dynamo_conflict_logs

Conversation

@rosstimothy
Copy link
Copy Markdown
Contributor

Alters the log messages from #40854 such that they only occur if the fallback mechanism fails.

Updates #46801

@rosstimothy rosstimothy added backport/branch/v14 no-changelog Indicates that a PR does not require a changelog entry backport/branch/v17 labels Nov 6, 2024
@github-actions github-actions bot added audit-log Issues related to Teleports Audit Log size/sm labels Nov 6, 2024
@aws-amplify-us-west-2
Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-48548.d3pp5qlev8mo18.amplifyapp.com

@rosstimothy
Copy link
Copy Markdown
Contributor Author

@greedy52 @gabrielcorado I only implemented the log suppression advice from #46801 and am not marking this as fixing said issue, unless you think this will suffice and there is nothing more to do.

Comment thread lib/events/dynamoevents/dynamoevents.go Outdated
Comment thread lib/events/dynamoevents/dynamoevents.go Outdated
Copy link
Copy Markdown
Contributor

@gabrielcorado gabrielcorado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Alters the log messages from #40854
such that they only occur if the fallback mechanism fails.

Updates #46801
@rosstimothy rosstimothy force-pushed the tross/dynamo_conflict_logs branch from e40c69e to 9e4f1d9 Compare November 7, 2024 17:47
@rosstimothy rosstimothy enabled auto-merge November 7, 2024 17:47
@rosstimothy rosstimothy added this pull request to the merge queue Nov 7, 2024
Merged via the queue into master with commit 53ccda9 Nov 7, 2024
@rosstimothy rosstimothy deleted the tross/dynamo_conflict_logs branch November 7, 2024 18:24
@public-teleport-github-review-bot
Copy link
Copy Markdown

@rosstimothy See the table below for backport results.

Branch Result
branch/v14 Failed
branch/v15 Failed
branch/v16 Failed
branch/v17 Create PR

rosstimothy added a commit that referenced this pull request Nov 7, 2024
…48548)

Alters the log messages from #40854
such that they only occur if the fallback mechanism fails.

Updates #46801
github-merge-queue bot pushed a commit that referenced this pull request Nov 7, 2024
…48548) (#48624)

Alters the log messages from #40854
such that they only occur if the fallback mechanism fails.

Updates #46801
github-merge-queue bot pushed a commit that referenced this pull request Nov 7, 2024
…48548) (#48626)

Alters the log messages from #40854
such that they only occur if the fallback mechanism fails.

Updates #46801
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

audit-log Issues related to Teleports Audit Log backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry size/sm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants