helm: Add serviceAccountName to pre-deploy jobs#48530
Merged
Conversation
webvictim
added
helm
backport/branch/v14
no-changelog
hugoShaka
approved these changes
Nov 6, 2024
tigrato
approved these changes
Nov 6, 2024
public-teleport-github-review-bot
Bot
removed request for
jimbishopp and
rosstimothy
hugoShaka
requested changes
Nov 6, 2024
Contributor
hugoShaka
left a comment
hugoShaka
left a comment
There was a problem hiding this comment.
This won't work because SA is not deployed yet during hooks
webvictim
force-pushed
the
gus/helm/predeploy-serviceaccounts
branch
from
27993ad to
0672e22
Compare
webvictim
force-pushed
the
gus/helm/predeploy-serviceaccounts
branch
from
0672e22 to
5456609
Compare
Contributor
Author
|
@hugoShaka Made a copy of the |
hugoShaka
approved these changes
Nov 6, 2024
|
@webvictim See the table below for backport results.
|
webvictim
removed
the
no-changelog
This was referenced Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48477
Note that the service account name used for the proxy will automatically have
-proxyappended to it, as in all other existing cases where theserviceAccount.namevalue is used.changelog: The teleport-cluster Helm chart now uses the configured serviceAccount.name from chart values for its pre-deploy configuration check Jobs.